Repository navigation
[API] fix paddle.diag with big tensor - #72638
Merged
Merged
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
ZhangX-21
force-pushed
the
fix_diag_big_tensor
branch
from
May 9, 2025 09:01
cf9638b to
a4b14a4
Compare
ZhangX-21
changed the title
ZhangX-21
force-pushed
the
fix_diag_big_tensor
branch
3 times, most recently
from
May 14, 2025 13:58
80aec86 to
b315d45
Compare
ZhangX-21
force-pushed
the
fix_diag_big_tensor
branch
from
May 14, 2025 15:53
b315d45 to
a4a9598
Compare
lshpku
reviewed
May 19, 2025
| int64_t x_length, | ||
| const int64_t sumStride, | ||
| const int64_t xStride) { | ||
| for (int64_t idx = blockIdx.x * blockDim.x + threadIdx.x; idx < x_length; |
Contributor
There was a problem hiding this comment.
这里blockIdx.x * blockDim.x会超过uint32吗？
Contributor
Author
There was a problem hiding this comment.
blockIdx.x * blockDim.x，取值范围不超过uint32, 但是idx < x_length在大Tensor场景下，所以需要采用int64_t的取值范围。
lshpku
reviewed
May 19, 2025
|
|
||
| if (x_dims.size() <= 1) { | ||
| int64_t size_ = (x_dims.size() == 1UL ? x_dims[0] : 1) + std::abs(offset); | ||
| int64_t size_ = (x_dims.size() == 1ULL ? x_dims[0] : 1) + std::abs(offset); |
Contributor
Author
There was a problem hiding this comment.
这个没有什么区别，只是修改支持unsigned long long int的取值。
lshpku
approved these changes
May 19, 2025
wanghuancoder
pushed a commit
to wanghuancoder/Paddle
that referenced
this pull request
May 27, 2025
wanghuancoder
added a commit
that referenced
this pull request
Jun 3, 2025
* refine forrange (#72360) * refine forrange * refine forrange * reduce support big tensor (#71970) * reduce support big tensor * [PHI] Fix gridDim limit for reduce kernel (#72507) * [API] isclose support bigtensor (#72516) * isclose support bigtensor * refine * [API] isnan isinf isfinite support bigtensor (#72517) * isnan isinf isfinite support bigtensor * refine * [PHI] Fix cum kernel for big tensor (#72562) * [PHI] Preliminary fix for elementwise broadcast int32 shape overflow (#72584) * [PHI] Align linalg.solve kernel with torch (#72608) * Update strided copy kernel (#72662) * [PHI] Fix grid sample kernel for big tensor (#72628) * [PHI] Fix argsort big tensor bug (#72712) * [PHI] Fixed argsort big tensor bug * [PHI] Fixed shape mismatch problem. * [PHI] Fix contiguous kernel for big tensor (#72705) * [PHI] Fix flatten and split kernel for big tensor (#72634) * [PHI] Fix out-of-bound issue of paddle.take_along_axis (#72757) * [PHI] fix paddle.diag with big tensor (#72638) * [API] fix paddle.cross with big tensor (#72652) * [PHI] Fix paddle.where api for big tensor (#72717) * [PHI] Fix bincount kernel for big tensor (#72706) * fix bincount kernel for big tensor * use HostAlloc to alloc memory * add cpu test case * [PHI] Fix full_like kernel for big tensor (#72831) * [API] Fix int overflow and float16 support for paddle.frac (#72815) * [PHI] Align paddle.inner with torch in matmul logic (#72843) * [PHI] Fix paddle.var & paddle.std float16 overflow (#72650) * [PHI] Fix logsumexp precision problem (#72681) * [PHI] Debug for logsumexp, bug source found * [PHI] Removed GetNumBlocks func to get correct logsumexp * [PHI] Removed redundant debug VLOG * [PHI] Elegant grid bounded solution * [Accuracy diff No.55-56、76-77] Fix accuracy diff for var&std API (#72879) * [Accuracy diff No.21] Fix accuracy diff for heaviside API (#72894) --------- Co-authored-by: Shuhao Liang <50269654+lshpku@users.noreply.github.com> Co-authored-by: Qianyue He <46109954+Enigmatisms@users.noreply.github.com> Co-authored-by: Lei Ding <69283446+Dmovic@users.noreply.github.com> Co-authored-by: ggggxm <66855582+ggggxm@users.noreply.github.com> Co-authored-by: xkkkkkk23 <xiekeke@baidu.com> Co-authored-by: Zx <zhangxiao35@baidu.com> Co-authored-by: huangjiyi <43315610+huangjiyi@users.noreply.github.com> Co-authored-by: ooo oo <106524776+ooooo-create@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
paddle.diag support big tensor shape
Pcard-88155
性能回退1%